Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle librespot Seeked events #1519

Merged
merged 1 commit into from
Sep 21, 2024
Merged

fix: Handle librespot Seeked events #1519

merged 1 commit into from
Sep 21, 2024

Conversation

hrkfdn
Copy link
Owner

@hrkfdn hrkfdn commented Sep 21, 2024

With librespot 0.5 the PlayerEvent behavior for track seeking seems to have changed slightly and there is now a dedicated event. This broke seeking in tracks.

With this change the dedicated event is processed and track position changes should be picked up again.

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • Documentation was updated (i.e. due to changes in keybindings, commands, etc.)
  • Changelog was updated with relevant user-facing changes (eg. not dependency updates,
    not performance improvements, etc.)

With librespot 0.5 the `PlayerEvent` behavior for track seeking seems to have
changed slightly and there is now a dedicated event. This broke seeking in
tracks.

With this change the dedicated event is processed and track position changes
should be picked up again.
@hrkfdn hrkfdn enabled auto-merge (rebase) September 21, 2024 11:31
@hrkfdn hrkfdn merged commit f8a0a31 into main Sep 21, 2024
5 checks passed
@hrkfdn hrkfdn deleted the hf/fix_seek branch September 21, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant